Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files are not considered "pub run test"-able if they are checked prior to .packages being created #2080

Closed
DanTup opened this issue Oct 30, 2019 · 0 comments
Labels
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Oct 30, 2019

This is causing a test flake. Something causes us to check if a file is runnable via pub test before packages are restored, and this value is cached (part of #1441) we end up never re-checking.

It seems like the requirement for .packages is a bit overkill - if there's a pubspec.yaml it should be safe to assume it's valid to run tests (pub will complain if the packages are not restored).

@DanTup DanTup added the is bug label Oct 30, 2019
@DanTup DanTup added this to the v3.6.0 milestone Oct 30, 2019
DanTup added a commit that referenced this issue Oct 30, 2019
This won't exist before you run getPackages, and because we cache the result (and can't easily invalidate it) it often gets out of date.

Fixes #2080.
@DanTup DanTup closed this as completed in 4c425b4 Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant