Color swatch preview is shown even if commented out

[lukepighetti]

[DanTup]

Yeah, I noticed this too. It's because the colour detection we do is pretty naive and just regex's the file. We don't really know (in the editor) what's a comment and what's not.

I think the best fix for this would be to move this to the server (probably as an LSP custom message once we've moved the editor fully over to LSP).

[DanTup]

This might not need to be a custom message, as LSP may have support for it already:

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_documentColor

[lukepighetti]

This is definitely a nit. I wouldn't mind at all if you closed it.

[DanTup]

I'll keep this issue open as a reminder that I need to implement this in LSP anyway (and can use the API above), whether or not it ends up with the same quirk :-)

[DanTup]

If/when moving this to LSP, we should try to make it pick the Colors class more reliably too (see #2857).

[DanTup]

The built-in color picker is now supported via the LSP server. It's a change in the SDK so will show up in a future SDK release rather than Dart-Code release. When the SDK you're using supports this, the legacy color previews will be disabled, so this problem will go away (since the server-generated are more reliable and not using regex).

dart-lang/sdk@3238b2c