Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code "Open in Xcode" does nothing #2178

Closed
jmagman opened this issue Dec 18, 2019 · 3 comments
Closed

VS Code "Open in Xcode" does nothing #2178

jmagman opened this issue Dec 18, 2019 · 3 comments
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@jmagman
Copy link

jmagman commented Dec 18, 2019

Steps to Reproduce

Open Flutter directory in VS Code on Mac OS X 10.14.6.
Context-click on ios directory > Open in Xcode

Nothing happens.

Logs

I see this log when I reproduce:

error	10:34:19.546912 -0800	Code Helper (Renderer)	nw_path_close_fd Failed to close guarded necp fd 48 [9: Bad file descriptor]

Flutter extension is marked "not activated" when I Capture Logs (no actual log lines when I reproduced) but I'm not sure if that's related. It looks enabled in the Extensions UI.

Dart Code extension: 3.7.1
Flutter extension: 3.7.1 (not activated)
VS Code: 1.41.0
Platform: mac
Workspace type: Flutter
Multi-root?: false
Dart SDK:
    Loc: /Users/m/Projects/flutter/bin/cache/dart-sdk
    Ver: 2.8.0-edge.fe9f30c3896e7146195ea52434c5082b309b6ee0
Flutter SDK:
    Loc: /Users/m/Projects/flutter
    Ver: 1.13.3-pre.59
HTTP_PROXY: undefined
NO_PROXY: undefined

Screen Shot 2019-12-18 at 10 44 36 AM

@DanTup
Copy link
Member

DanTup commented Dec 19, 2019

I can't repro this - it seems to work ok. We look in the folder for xcworkspace/xcodeproj files (preferring xcworkspace) and then open it with:

open -a Xcode [path-to-file]

If you try running that command from a terminal, does it work?

@DanTup DanTup added the awaiting info Requires more information from the customer to progress label Dec 19, 2019
@jmagman
Copy link
Author

jmagman commented Dec 19, 2019

If you try running that command from a terminal, does it work?

Ah, my Xcode is named Xcode_11-3.

open -a Xcode [path-to-file]
Unable to find application named 'Xcode'

You could change it to open [path-to-file] since that should also open in Xcode.
I'm okay with you closing this, too, since I'm not using the default app name.

@DanTup
Copy link
Member

DanTup commented Dec 19, 2019

If opening the file works directly, I'll change it to do that. I'll also see if I can improve how it fails if it doesn't work (silently doing nothing isn't a good experience - seems like we should be able to detect this and display a message).

@DanTup DanTup added in editor Relates to code editing or language features is bug and removed awaiting info Requires more information from the customer to progress labels Dec 19, 2019
@DanTup DanTup added this to the v3.8.0 milestone Dec 19, 2019
DanTup added a commit that referenced this issue Dec 23, 2019
This works if the Xcode binary is named something else.

Fixes ##2178.
@DanTup DanTup closed this as completed in 7198191 Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

2 participants