Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code "Open in Xcode" opens Runner.xcodeproj, should open Runner.xcworkspace #2179

Closed
jmagman opened this issue Dec 18, 2019 · 2 comments
Closed
Labels
in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug
Milestone

Comments

@jmagman
Copy link

jmagman commented Dec 18, 2019

Opening a Flutter app in Xcode should open Runner.xcworkspace, not Runner.xcodeproj.
See https://flutter.dev/docs/deployment/ios#create-a-build-archive and flutter/flutter#10770

User report from @kinex at firebase/flutterfire#1258 (comment)

I had opened it from VS Code by right-clicking in the explorer MyApp / ios folder and then selecting Open in Xcode. Apparently it opens Runner.xcodeproj because if I now open Runner.xcworkspace directly, I can create an archive normally. Not sure is there some reason that VS Code opens .xcodeproj or is that something that should be fixed.

I wasn't able to reproduce this myself due to #2178.

Logic at

.sort((f1, f2) => f1.name.endsWith(".xcworkspace") ? 0 : 1);
looks right to me, but I'm not sure what version @kinex is on.

@kinex
Copy link

kinex commented Dec 18, 2019

I have VS Code version 1.41.0 / Flutter extension version 3.7.1

I am not so familiar with TypeScript, but should that be
.sort((f1, f2) => f1.name.endsWith(".xcworkspace") ? -1 : 1);

@DanTup
Copy link
Member

DanTup commented Dec 19, 2019

Good catch! I guess I didn't properly verify which one was opening when I did this 🙈

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug
Projects
None yet
Development

No branches or pull requests

3 participants