Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Outline Doesn't Always Display Outline #2228

Closed
quiverware opened this issue Jan 22, 2020 · 6 comments · Fixed by #2272
Closed

Flutter Outline Doesn't Always Display Outline #2228

quiverware opened this issue Jan 22, 2020 · 6 comments · Fixed by #2272
Labels
awaiting info Requires more information from the customer to progress in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug
Milestone

Comments

@quiverware
Copy link

I found this bug when I went to the definition of the Flutter Navigator class. I'm running version 3.7.1 of the Dart and Flutter VSCode extensions.

Steps to reproduce the bug:

  1. Click on NavigatorState in my code (the Flutter class probably doesn't matter but this is how I found the bug).
  2. The file navigator.dart opens in VSCode. Clicking on the Flutter icon in the sidebar correctly shows an outline for the Flutter / Dart code.
  3. Click on a tab of a different file in the editor. In my case, it was one of my project files. An outline of the Flutter / Dart code is properly displayed.
  4. Click back on the navigator.dart tab in the editor. The Flutter outline pane is blank.

If I close and reopen the navigator.dart file the Flutter outline is displayed but whenever I click to view another file then click back the navigator.dart Flutter outline is blank.

@DanTup DanTup added this to the v3.8.0 milestone Jan 23, 2020
@DanTup DanTup added in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug labels Jan 23, 2020
@DanTup DanTup modified the milestones: v3.8.0, v3.9.0 Jan 24, 2020
@DanTup
Copy link
Member

DanTup commented Jan 27, 2020

I think this might be related to an issue I saw and fixed in a7ebb71. Could you see if it's fixed by v3.8.0 Beta 1?

https://github.com/Dart-Code/Dart-Code/releases/tag/v2.8.0-beta.1

Thanks!

@quiverware
Copy link
Author

quiverware commented Jan 27, 2020 via email

@DanTup
Copy link
Member

DanTup commented Feb 24, 2020

Sorry for the delay in responding. Are you able to reproduce this in a project you can share to see if I can repro?

@DanTup DanTup added the awaiting info Requires more information from the customer to progress label Feb 24, 2020
@quiverware
Copy link
Author

quiverware commented Feb 24, 2020 via email

@DanTup
Copy link
Member

DanTup commented Feb 26, 2020

Thanks! I was able to repro with the steps above. Seems like the way we forced updates for the Outline didn't work for SDK files so it wouldn't work after the first time. We now just read the last outline we had for a file in this case which should resolve the problem.

Thanks!

@quiverware
Copy link
Author

quiverware commented Feb 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting info Requires more information from the customer to progress in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants