Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use Backspace when using Terminal mode for Debugging #2230

Closed
ahmadalzoubi13579 opened this issue Jan 23, 2020 · 5 comments
Closed

Can't use Backspace when using Terminal mode for Debugging #2230

ahmadalzoubi13579 opened this issue Jan 23, 2020 · 5 comments
Labels
in cli Relates to running Dart CLI scripts in debugger Relates to the debug adapter or process of launching a debug session is bug
Milestone

Comments

@ahmadalzoubi13579
Copy link

  • VSCode Version: 1.41.1
  • OS Version: Windows 10 Pro 64-bit (10.0, Build 18362)

Steps to Reproduce:

  1. create launch.json
  2. write "console": "terminal" in your configurations
  3. write the following code that take an input from user :
import 'dart:io';

main() {
  stdout.writeln('what is Your Name ?');
  String name = stdin.readLineSync();
  print('Welcome $name');
}
  1. start debugging

then i can input value , but i can't use backspace key to undo the text while i write in console.

Untitled

@DanTup DanTup added this to the v3.9.0 milestone Jan 23, 2020
@DanTup DanTup added in cli Relates to running Dart CLI scripts in debugger Relates to the debug adapter or process of launching a debug session is bug labels Jan 23, 2020
@DanTup
Copy link
Member

DanTup commented Feb 13, 2020

@gogoIsComing I was (literally!) just looking at this! I can repro in both Stable and Insiders - what's the reason you closed it?

@DanTup
Copy link
Member

DanTup commented Feb 13, 2020

This happens even using the VS Code "local echo" sample code in the docs, and it's not clear whether it's fixable in the extension. I've opened microsoft/vscode#90618.

Re-opening this issue because it seems a certain bug, and it's not clear if we need to do work here yet.

@DanTup DanTup reopened this Feb 13, 2020
@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Feb 13, 2020
@ahmadalzoubi13579
Copy link
Author

ahmadalzoubi13579 commented Feb 13, 2020

@DanTup i already opened an issue microsoft/vscode#89139 (before current issue)
and they closed it , cause they thought it is extension issue

here the answer i got

@DanTup
Copy link
Member

DanTup commented Feb 13, 2020

@gogoIsComing ah, thanks! It may be an extension issue, but the sample code fails in the same way and I can't see a way in the API for us to handle it. I'll keep this open while waiting for a response though. Thanks!

@DanTup DanTup removed the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Feb 13, 2020
@DanTup
Copy link
Member

DanTup commented Feb 13, 2020

Ok, looks like this is by-design in VS Code, so we'll need to fix another way. It seems silly to implement it as suggested (we'd end up with a lot of code just to pretend to be a terminal) so I'm going to switch from the pseudoterminal to a real terminal and use dart-lang/sdk#38418 to connect the debugger.

@DanTup DanTup changed the title can't use Backspace in console during Debugging Can't use Backspace when using Terminal mode for Debugging Feb 13, 2020
DanTup added a commit that referenced this issue Mar 17, 2020
DanTup added a commit that referenced this issue Mar 19, 2020
Debug adapter sends a custom event to the editor allowing it to spawn the process locally, and watches for the --write-service-info file to connect to the VM.

Fixes #2230.
DanTup added a commit that referenced this issue Mar 23, 2020
Debug adapter sends a custom event to the editor allowing it to spawn the process locally, and watches for the --write-service-info file to connect to the VM.

Fixes #2230.
DanTup added a commit that referenced this issue Mar 23, 2020
@DanTup DanTup closed this as completed in 73a9bc3 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in cli Relates to running Dart CLI scripts in debugger Relates to the debug adapter or process of launching a debug session is bug
Projects
None yet
Development

No branches or pull requests

2 participants