Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not detecting the scope variable #2237

Closed
daniel-scatigno opened this issue Jan 28, 2020 · 3 comments
Closed

Not detecting the scope variable #2237

daniel-scatigno opened this issue Jan 28, 2020 · 3 comments
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@daniel-scatigno
Copy link

After inspecting the scope, the extension did not detected the variable, instead it detected as generic "source.dart"
I think it should have been detected as "variable.name.source.dart"

image

@DanTup
Copy link
Member

DanTup commented Jan 28, 2020

I think this may be solved by #2203, which is work to move from the TextMate grammar file to using semantic info from the analysis server directly (this will make it more accurate and solve a couple of bugs we have).

Finishing/merging the work requires VS Code finalizing (and shipping) the API which seems to be assigned to the February release.

@DanTup DanTup added this to the v3.9.0 milestone Jan 28, 2020
@DanTup DanTup added in editor Relates to code editing or language features is bug labels Jan 28, 2020
@DanTup DanTup modified the milestones: v3.9.0, On Deck Mar 11, 2020
@DanTup DanTup modified the milestones: On Deck, Backlog Jul 2, 2020
@DanTup DanTup modified the milestones: On Deck, v3.18.0 Dec 10, 2020
@DanTup
Copy link
Member

DanTup commented Dec 15, 2020

With the semantic token work in dart-lang/sdk@cb2ede5 you'll now be able to theme using semantic tokens instead, which will produce more reliable tokens. In the example above, there will be a property token with the declaration modifier for itemSuggestions.

In order to get the fix you'll need Dart-Code v3.18.0 (a preview release should be available later today/tomorrow), be using LSP Preview, and have a Dart SDK from after yesterday (the most recent nightly works, and of course the next releases of Dart/Flutter SDKs will include this).

@DanTup DanTup closed this as completed Dec 15, 2020
@DanTup DanTup modified the milestones: v3.18.0, v3.19.0 Dec 22, 2020
@DanTup
Copy link
Member

DanTup commented Dec 22, 2020

Due to some last minute issues, support for LSP 3.16 (which supports semantic tokens) won't be included in v3.18, but hopefully the next release after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

2 participants