Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support (as a preview option) using the LSP protocol for analysis server communications #2238

Closed
vogella opened this issue Jan 28, 2020 · 4 comments
Labels
in editor Relates to code editing or language features is enhancement
Milestone

Comments

@vogella
Copy link

vogella commented Jan 28, 2020

In Eclipse L4P4E I see the following log messages:

[t=1580217833406] LSP4E to org.eclipse.dartboard.server:
{"jsonrpc":"2.0","id":"37","method":"textDocument/completion","params":{"textDocument":

The logging in Dartcode seems not to be logging the language server communication but the analysis server:

3:03:38 PM] [Analyzer] [Info] <== {"event":"completion.availableSuggestions",

Is is planned to move the logging to LSP based communication.

@DanTup
Copy link
Member

DanTup commented Jan 28, 2020

Right now the Dart extension doesn't use LSP. What you're seeing logged is the original analysis server protocol (pre-LSP). It should essentially have the same contents, just in a different form (though completions are a bit tricky, since availableSuggestions are a way to preload them into the editor for performance reasons).

There is ongoing work to migrate to LSP (currently only on the lsp branch here) and as part of that, the logging would show LSP traffic instead of the original JSON protocol. I'm hoping to merge it soon (probably sometime in Feb) so that it would available for testing (though there are still some rough edges or unimplemented functionality).

I don't think there's actually an issue for this work (there is a project here) so I'll rename this one slightly for it.

@DanTup DanTup changed the title Capture Logs via DartCode does not show language server protocol messages Support (as a preview option) using the LSP protocol for analysis server communications Jan 28, 2020
@DanTup DanTup added this to the v3.9.0 milestone Jan 28, 2020
@DanTup DanTup added is enhancement in editor Relates to code editing or language features labels Jan 28, 2020
@DanTup DanTup closed this as completed in 762cdff Mar 30, 2020
@bsutton
Copy link

bsutton commented Oct 21, 2020

I don't believe so. I've just uninstalled flutter/dart-code and then re-installed the standard flutter extension from the market place which re-installed dart-code.

The same problem persists.

@DanTup
Copy link
Member

DanTup commented Oct 22, 2020

@bsutton was that comment intended for another issue?

@bsutton
Copy link

bsutton commented Oct 22, 2020

Sorry yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is enhancement
Projects
None yet
Development

No branches or pull requests

3 participants