Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support folder renames/moves #2483

Closed
DanTup opened this issue May 21, 2020 · 4 comments
Closed

Support folder renames/moves #2483

DanTup opened this issue May 21, 2020 · 4 comments
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Milestone
v3.48.0

Comments

@DanTup
Copy link
Member

DanTup commented May 21, 2020

No description provided.

@DanTup DanTup added is enhancement in editor Relates to code editing or language features labels May 21, 2020
@DanTup DanTup added this to the On Deck milestone May 21, 2020
@DanTup DanTup mentioned this issue May 21, 2020
Closed
@DanTup DanTup modified the milestones: On Deck, Backlog Jul 2, 2020
@DanTup DanTup modified the milestones: On Deck, v3.14.0 Aug 10, 2020
@DanTup DanTup modified the milestones: v3.14.0, v3.15.0 Aug 25, 2020
DanTup added a commit that referenced this issue Sep 9, 2020
@DanTup
Add plubming for updating imports when renaming folders (in-progress)
64875bb 
This is disabled with a flag, but the flag makes it easier to enable when testing SDK changes.

See #2483.
@DanTup DanTup modified the milestones: v3.15.0, On Deck Sep 21, 2020
@DanTup DanTup added the in lsp/analysis server Something to be fixed in the Dart analysis server label Sep 21, 2020
@DanTup DanTup changed the title Support multiple files and folders for moves/renames Support folder renames/moves Sep 21, 2020
@DanTup DanTup mentioned this issue Oct 5, 2020
Closed
@DanTup DanTup mentioned this issue Oct 15, 2020
Closed
@DanTup DanTup mentioned this issue Apr 7, 2021
Closed
@tmaihoff
Copy link

tmaihoff commented Nov 8, 2021

Hi, do we have an update here about folder renaming in dart?

@DanTup
Copy link
Member Author

DanTup commented Nov 8, 2021

No update yet, though I would like to try and get back to this soon.

@DanTup DanTup modified the milestones: On Deck, v3.36.0 Jan 18, 2022
@DanTup
Copy link
Member Author

DanTup commented Jan 18, 2022

I have been been working on this, but it's currently blocked by an issue in VS Code/LSP where clicking "cancel" on the notification for slow refactors does not pass the message to the server (which means if you rename a large folder then click cancel, the server will continue to perform the rename in the background).

Fixes are in progress for that, but not released. Once they are, I hope to complete this.

@DanTup DanTup modified the milestones: v3.36.0, v3.38.0 Feb 10, 2022
@DanTup DanTup modified the milestones: v3.38.0, v3.39.0 Mar 21, 2022
@DanTup DanTup removed this from the v3.40.0 milestone Apr 27, 2022
@DanTup DanTup added this to the v3.42.0 milestone Apr 27, 2022
This was referenced May 11, 2022
Closed
Open
@DanTup DanTup modified the milestones: v3.42.0, v3.44.0 May 25, 2022
@DanTup DanTup modified the milestones: v3.44.0, v3.46.0 Jun 21, 2022
@DanTup DanTup modified the milestones: v3.46.0, v3.48.0 Jul 25, 2022
@DanTup
Copy link
Member Author

DanTup commented Aug 23, 2022

This has landed in the server and is available in the current Flutter beta channel.

@DanTup DanTup closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Projects
None yet
Milestone
v3.48.0
Development

No branches or pull requests
2 participants
@DanTup @tmaihoff