Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users in China do not get automatic updates for DevTools #2503

Closed
DanTup opened this issue May 28, 2020 · 2 comments
Closed

Users in China do not get automatic updates for DevTools #2503

DanTup opened this issue May 28, 2020 · 2 comments
Labels
in commands Relates to commands (usually invoked from the command Palette) is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented May 28, 2020

See #2486 and #2502. If the Pub website is blocked, the API check for versions will also fail, and we'll never update.

Some possible options:

  • Call the API on pub.flutter-io.cn (if supported) if the first request fails
  • Always try to update DevTools in the background at startup (note: this might mess with people using locally-activated versions)
  • Periodically prompt the user to update ("Unable to check for updates, install latest version?" or similar)
@DanTup DanTup added is enhancement in commands Relates to commands (usually invoked from the command Palette) labels May 28, 2020
@DanTup DanTup added this to the v3.12.0 milestone May 28, 2020
This was referenced May 28, 2020
@beilly
Copy link

beilly commented May 28, 2020

@DanTup Give a option setting API on pub.flutter-io.cn, and default pub.dev. Otherwise, always update manually. If you have any help with the test, please contact me.

@DanTup
Copy link
Member Author

DanTup commented Jun 16, 2020

Looks like we don't need a setting - we can just read PUB_HOSTED_URL which should already be set by users in China for Flutter/pub to work correctly (see https://flutter.dev/community/china) :-)

@DanTup DanTup closed this as completed in 0266091 Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants