Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight confusing in unicode string formatting #2575

Closed
tgarm opened this issue Jun 22, 2020 · 1 comment
Closed

Syntax highlight confusing in unicode string formatting #2575

tgarm opened this issue Jun 22, 2020 · 1 comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server
Milestone

Comments

@tgarm
Copy link

tgarm commented Jun 22, 2020

When syntax highlight a unicode string, the syntax highlight does not very correct.
For instance, to format a value val in string may look like:

  • Without bracket
    WeChate216463751653492a1ec45db890cf583

This seems will format val世界 instead of val.

  • With bracket
    WeChat50ebba0060b5bfb3b4adfa2492c7cc74

This shows brackets are not needed.

It seems confusing how to correctly format val in this string in this syntax highlight.

@DanTup
Copy link
Member

DanTup commented Jun 22, 2020

Thanks for the report! There are quite a few issues with the current syntax highlighting. The goal is to fix them when adopting server-provided highlights through LSP (in #2202) since the server will produce reliable highlights using the real Dart parser, rather than using regex.

@DanTup DanTup added this to the On Deck milestone Jun 22, 2020
@DanTup DanTup added blocked on vs code / lsp / dap Requires a change in VS Code to progress in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server labels Jun 22, 2020
@DanTup DanTup modified the milestones: On Deck, Backlog Jul 2, 2020
@DanTup DanTup modified the milestones: Backlog, v3.18.0 Nov 25, 2020
@DanTup DanTup removed the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Nov 25, 2020
@DanTup DanTup closed this as completed in 03a19d7 Dec 9, 2020
DanTup added a commit to DanTup/dart-syntax-highlight that referenced this issue May 21, 2021
devoncarew pushed a commit to dart-lang/dart-syntax-highlight that referenced this issue May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server
Projects
None yet
Development

No branches or pull requests

2 participants