Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't jump into libraries from integrated terminal stack traces #2581

Closed
mymikemiller opened this issue Jun 23, 2020 · 6 comments
Closed

Can't jump into libraries from integrated terminal stack traces #2581

mymikemiller opened this issue Jun 23, 2020 · 6 comments
Labels
in editor Relates to code editing or language features is enhancement
Milestone

Comments

@mymikemiller
Copy link

I'm not sure if this is an issue for the Dart-Code extension or if it's a VSCode thing (or if I just have some setting wrong), but I figured I'd start here.

When I print out a stack trace and click on a file link, VSCode fails to navigate to package files in my pub_cache.

For illustrative purposes in the screenshots, I navigated to the file by jumping to it when debugging. The file does not pop up when cmd+clicking the link.

before

after

@mymikemiller
Copy link
Author

Note that searching the workspace for the text of the line does show the result, and I can click into the line in the editor.

Screen Shot 2020-06-23 at 2 55 45 PM

@DanTup
Copy link
Member

DanTup commented Jun 24, 2020

This is unfortunately a limitation of VS Code. We have no ability to tell the terminal the terminal about package: links so it's unable to detect them and link them. You could raise this as a feature request at https://github.com/microsoft/vscode/issues and if an API was provided that allowed us to handle link detection for the terminal, we could contribute some rules.

Out of interest though - why are you running the app in the terminal?

@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Jun 24, 2020
@DanTup DanTup added this to the Backlog milestone Jun 24, 2020
@mymikemiller
Copy link
Author

Good to know, thanks.

I'm using the terminal because the debug console doesn't support cursor positioning and I want to print pretty progress bars and stuff. Also the debug console isn't interactive.

@mymikemiller
Copy link
Author

Filed a VSCode feature request: microsoft/vscode#101041

@Tyriar
Copy link

Tyriar commented Jun 25, 2020

The terminal link provider API just hit proposed, still open to feedback and it may change before becoming stable microsoft/vscode#91290

@DanTup
Copy link
Member

DanTup commented Jun 25, 2020

@Tyriar aha! I thought I'd seen it somewhere, but couldn't find it when searching the other day! I'll check it out and see if it does what we'd need. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is enhancement
Projects
None yet
Development

No branches or pull requests

3 participants