Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping the elements #2600

Closed
Goolpe opened this issue Jul 1, 2020 · 1 comment
Closed

Wrapping the elements #2600

Goolpe opened this issue Jul 1, 2020 · 1 comment
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@Goolpe
Copy link

Goolpe commented Jul 1, 2020

I tried to wrap multiple elements in a column or a raw with Ctrl + . and ran into a problem
Let's try combine two elements:

image -> image

Elements on the same line, works fine:

image -> image

Combine elements in widget (difference in one space selection before elements)

image -> image
image -> image

flutter doctor -v
[✓] Flutter (Channel beta, 1.19.0-4.2.pre, on Linux, locale ru_RU.UTF-8)
    • Flutter version 1.19.0-4.2.pre at /home/ads/flutter
    • Framework revision 9b9b543d92 (9 дней назад), 2020-06-22 12:19:28 -0700
    • Engine revision 9a28c3bcf4
    • Dart version 2.9.0 (build 2.9.0-14.1.beta)

 
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /home/ads/Android/Sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /snap/android-studio/84/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /snap/android-studio/84/android-studio
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] IntelliJ IDEA Community Edition (version 2019.3)
    • IntelliJ at /home/ads/idea
    • Flutter plugin version 44.0.3
    • Dart plugin version 193.6911.25

[✓] VS Code (version 1.42.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.8.1

[✓] Connected device (3 available)
    • ZTE BLADE A0622 • 320376181424 • android-arm    • Android 7.1.1 (API 25)
    • Web Server      • web-server   • web-javascript • Flutter Tools
    • Chrome          • chrome       • web-javascript • Google Chrome 80.0.3987.116

@DanTup
Copy link
Member

DanTup commented Jul 1, 2020

Thanks for the report! This code didn't take into account multi-line selections when calculating the length of the selection (it just did end.character - start.character). I've fixed this for the next version. Thanks!

@DanTup DanTup added this to the v3.13.0 milestone Jul 1, 2020
@DanTup DanTup closed this as completed in 3e5b08d Jul 1, 2020
@DanTup DanTup added in editor Relates to code editing or language features is bug labels Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

2 participants