Show full untruncated messages from dart:developer log()

[szotp]

developer.log output is truncated so much that it's almost useless. IMO it would be better to just print entire thing - if I wanted to truncate, I could do it before calling the log method.

import 'dart:developer';

void main(List<String> arguments) {
  const text1 =
      "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.";

  final text2 =
      Iterable.generate(100, (i) => 'Lorem ipsum dolor sit amet').join('\n');

  log(text1);
  log(text2);
}

Outputs:

[log] Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut e…
[log] Lorem ipsum dolor sit amet
      Lorem ipsum dolor sit amet
      Lorem ipsum dolor sit amet
      Lorem ipsum dolor sit amet
      Lorem ipsum dolor si…
Exited

I suspect that this line needs to be changed:

Dart-Code/src/debug/dart_debug_impl.ts

Line 1598 in 6ad3ce7

const message = (record.message.valueAsString || "<empty message>")

To use fullValueAsString:

Dart-Code/src/debug/dart_debug_impl.ts

Line 1605 in 6ad3ce7

const message = await this.fullValueAsString(event.isolate, record.error);

I'm going to try if it works and submit MR.

I also checked on Android studio and did not have this truncation.

[DanTup]

On the surface that seems like a reasonable change to me. There's a test here you might want to extend/copy with a longer message:

Dart-Code/src/test/dart_debug/debug/dart_cli.test.ts

Line 131 in b3b9555

dc.assertOutputContains("console", `${grey("[log] ")}Logging from dart:developer!`),

Thanks!

[szotp]

PR sent #2684