-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack traces in test errors are not linkified #2794
Comments
With this and #2795 fixed, it now looks like this: We can't currently map |
That's awesome @DanTup - thank you for fixing this so quickly! 👍 |
@DanTup I installed the v3.15 beta vsix, both reloaded and then restarted vsc for good measure but when running tests I still don't seem to see the test failure relative stack traces being linked? |
@maks oh, that's a different place again. In the original screenshot it was the Debug Console (which we parse the output for and attach location metadata). The other one was the Terminal (where we now detect package: links with a regex, and VS Code does the path links). This one is the Output Pane (which we show if you click back on a test node in the tree). As far as I know, there's no way for us to provide links there (though I think in theory the link provider code would work there if we had a hook - @Tyriar does that seem like a useful feature request?). I wonder if we could switch to using a pseudo terminal for those results now instead of an Output pane. That would probably get VS Code's normal linking (which I presume includes relative paths) as well as our link provider (for |
There's been some talk of sharing terminal link logic with the output panel: microsoft/vscode#107314, microsoft/vscode#53922 |
See #2099 (comment)
The text was updated successfully, but these errors were encountered: