Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack traces in test errors are not linkified #2794

Closed
DanTup opened this issue Sep 15, 2020 · 5 comments
Closed

Stack traces in test errors are not linkified #2794

DanTup opened this issue Sep 15, 2020 · 5 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session in testing Relates to test execution of Dart/Flutter tests for end users is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Sep 15, 2020

See #2099 (comment)

Screenshot 2020-09-15 at 10 20 16

@DanTup DanTup added this to the v3.15.0 milestone Sep 15, 2020
@DanTup DanTup added in debugger Relates to the debug adapter or process of launching a debug session in testing Relates to test execution of Dart/Flutter tests for end users is bug labels Sep 15, 2020
@DanTup
Copy link
Member Author

DanTup commented Sep 15, 2020

With this and #2795 fixed, it now looks like this:

Screenshot 2020-09-15 at 10 28 01

We can't currently map dart:async anywhere so it remains in the message on the left (we can't attach a link that would appear on the right), but I think it's an improvement (ignoring the not-so-friendly async stack traces, but that's not something we can improve in the extension).

DanTup added a commit that referenced this issue Sep 15, 2020
DanTup added a commit that referenced this issue Sep 15, 2020
@maks
Copy link

maks commented Sep 16, 2020

That's awesome @DanTup - thank you for fixing this so quickly! 👍

@DanTup DanTup closed this as completed in b9fc02c Sep 16, 2020
DanTup added a commit that referenced this issue Sep 16, 2020
@maks
Copy link

maks commented Sep 28, 2020

@DanTup I installed the v3.15 beta vsix, both reloaded and then restarted vsc for good measure but when running tests I still don't seem to see the test failure relative stack traces being linked?

Screenshot 2020-09-28 at 10 05 53

@DanTup
Copy link
Member Author

DanTup commented Sep 28, 2020

@maks oh, that's a different place again. In the original screenshot it was the Debug Console (which we parse the output for and attach location metadata). The other one was the Terminal (where we now detect package: links with a regex, and VS Code does the path links). This one is the Output Pane (which we show if you click back on a test node in the tree). As far as I know, there's no way for us to provide links there (though I think in theory the link provider code would work there if we had a hook - @Tyriar does that seem like a useful feature request?).

I wonder if we could switch to using a pseudo terminal for those results now instead of an Output pane. That would probably get VS Code's normal linking (which I presume includes relative paths) as well as our link provider (for package: paths). I've opened #2825 to have a look at that.

@Tyriar
Copy link

Tyriar commented Nov 6, 2020

There's been some talk of sharing terminal link logic with the output panel: microsoft/vscode#107314, microsoft/vscode#53922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session in testing Relates to test execution of Dart/Flutter tests for end users is bug
Projects
None yet
Development

No branches or pull requests

3 participants