Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug adapter consumes CPU when large messages are printed #2877

Closed
DanTup opened this issue Oct 14, 2020 · 0 comments
Closed

Debug adapter consumes CPU when large messages are printed #2877

DanTup opened this issue Oct 14, 2020 · 0 comments
Labels
important Something important! in debugger Relates to the debug adapter or process of launching a debug session is bug is performance
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Oct 14, 2020

Adding:

print('A' * 5000);

To a Fluter project and then running it causes a hang (around 45 seconds on my machine) for the print. Larger messages take many minutes.

The time is being spent in looking for stack frames:

const frame = this.getStackFrameData(message) || this.getWebStackFrameData(message) || this.getMessageWithUriData(message);

These regexes were modified in the latest release, so it's likely those changes have caused this.

@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session is performance important Something important! labels Oct 14, 2020
@DanTup DanTup added this to the v3.15.1 milestone Oct 14, 2020
@DanTup DanTup pinned this issue Oct 14, 2020
DanTup added a commit that referenced this issue Oct 15, 2020
Additional performance improvement for #2877.
DanTup added a commit that referenced this issue Oct 15, 2020
Additional performance improvement for #2877.
@DanTup DanTup closed this as completed in 3123f1b Oct 15, 2020
@DanTup DanTup unpinned this issue Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Something important! in debugger Relates to the debug adapter or process of launching a debug session is bug is performance
Projects
None yet
Development

No branches or pull requests

1 participant