Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming a library fails to refactor imports #2893

Closed
bsutton opened this issue Oct 19, 2020 · 4 comments
Closed

renaming a library fails to refactor imports #2893

bsutton opened this issue Oct 19, 2020 · 4 comments
Labels
awaiting info Requires more information from the customer to progress is bug stale Will be closed soon if no response.

Comments

@bsutton
Copy link

bsutton commented Oct 19, 2020

In the vscode file explorer view you can rename a library by selecting the library and the opening the context menu and choosing 'rename'.

Previously once you renamed a library all of the other libraries that imported that library would be updated to use the new library name.

The imports are no longer being updated.

The same goes if you move a library between directories i.e. the imports are no longer updated.

@bsutton bsutton added the is bug label Oct 19, 2020
@DanTup
Copy link
Member

DanTup commented Oct 21, 2020

Are you using the LSP preview? That doesn't work in LSP yet, it's blocked on the LSP spec getting support for the necessary events which I've got a PR open for at microsoft/language-server-protocol#1074.

@DanTup DanTup added the awaiting info Requires more information from the customer to progress label Oct 21, 2020
@bsutton
Copy link
Author

bsutton commented Oct 22, 2020

I don't believe so. I've just uninstalled flutter/dart-code and then re-installed the standard flutter extension from the market place which re-installed dart-code.

The same problem persists.

@DanTup
Copy link
Member

DanTup commented Oct 26, 2020

@bsutton could you try capturing a log?

  • Run the Dart: Capture Logs command (leave everything ticked and just hit OK)
  • Rename the file
  • Click Cancel on the logging dialog

Note: The log may contain parts of your source code. You can mail it to logs@dartcode.org or attach it here.

It's also worth double-checking this option is ticked if you haven't already (though I think it should be by default):

Screenshot 2020-10-26 at 13 52 58

@github-actions
Copy link

This issue has been marked stale because it is tagged awaiting-info for 30 days with no activity. Remove the stale label or comment to prevent the issue being closed in 10 days.

@github-actions github-actions bot added the stale Will be closed soon if no response. label Nov 26, 2020
@github-actions github-actions bot closed this as completed Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting info Requires more information from the customer to progress is bug stale Will be closed soon if no response.
Projects
None yet
Development

No branches or pull requests

2 participants