Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack frames are not linkified in Dart SDK tests #2910

Closed
DanTup opened this issue Oct 28, 2020 · 0 comments
Closed

Stack frames are not linkified in Dart SDK tests #2910

DanTup opened this issue Oct 28, 2020 · 0 comments
Labels
in cli Relates to running Dart CLI scripts in debugger Relates to the debug adapter or process of launching a debug session in testing Relates to test execution of Dart/Flutter tests for end users is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Oct 28, 2020

Running test/src/services/correction/fix/bulk/remove_not_null_assertion_test.dart, the stack trace is not linked at all:

Screenshot 2020-10-28 at 12 19 57

@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session in cli Relates to running Dart CLI scripts in testing Relates to test execution of Dart/Flutter tests for end users labels Oct 28, 2020
@DanTup DanTup added this to the v3.17.0 milestone Oct 28, 2020
@DanTup DanTup closed this as completed in cf08c4e Nov 18, 2020
DanTup added a commit that referenced this issue Nov 19, 2020
A better fix for #2910. This uses a very fast check to determine whether a (potentially huge) message has stack frames, before splitting into lines and using the (slower) frame-extraction regex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in cli Relates to running Dart CLI scripts in debugger Relates to the debug adapter or process of launching a debug session in testing Relates to test execution of Dart/Flutter tests for end users is bug
Projects
None yet
Development

No branches or pull requests

1 participant