Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VM Service getStack() limit argument to speed up fetching stacks on web #2933

Closed
DanTup opened this issue Nov 4, 2020 · 0 comments
Closed
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement is performance
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Nov 4, 2020

Computing the call stack on web can be slow, and we have to do the entire thing even when VS Code only wants the top 20 frames.

The VM service is getting support for fetching a slice:

dart-lang/sdk@89de1e8

And I found that if we just give VS Code a totalFrames or requestedFrames + batchSize, it will happily call us multiple times with batches (this is not spec'd behaviour, but it seems worth the trade-off of possibly having to revert/update in future).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement is performance
Projects
None yet
Development

No branches or pull requests

1 participant