Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate test running to "dart run" for tests #2950

Closed
DanTup opened this issue Nov 10, 2020 · 2 comments · Fixed by #2956
Closed

Migrate test running to "dart run" for tests #2950

DanTup opened this issue Nov 10, 2020 · 2 comments · Fixed by #2956
Labels
in debugger Relates to the debug adapter or process of launching a debug session in testing Relates to test execution of Dart/Flutter tests for end users is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Nov 10, 2020

From #2949 (comment)

I tried using dart test, though I found that with --pause_isolates_on_start=true it would be paused but not print the VM Service URI. If I tried adding --write-service-info=foo.txt it also didn't write the VM Service info there. I don't know whether those are complicated or simple things to address though.

@DanTup DanTup added the in testing Relates to test execution of Dart/Flutter tests for end users label Nov 10, 2020
@DanTup DanTup added this to the On Deck milestone Nov 10, 2020
@sigurdm
Copy link

sigurdm commented Nov 13, 2020

I believe these are bugs to be fixed.

@DanTup DanTup changed the title Migrate test running to "dart test" Migrate test running to "dart run" for tests Nov 13, 2020
@DanTup DanTup modified the milestones: On Deck, v3.17.0 Nov 13, 2020
@DanTup DanTup added is enhancement in debugger Relates to the debug adapter or process of launching a debug session labels Nov 13, 2020
@DanTup
Copy link
Member Author

DanTup commented Nov 13, 2020

@sigurdm @jonasfj thanks for the call! Switching to dart run test:test appears to work perfectly! I've got a PR to revert the previous workaround and make that change for >= v2.12 at #2956. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session in testing Relates to test execution of Dart/Flutter tests for end users is enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants