Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the pause event's topFrame to satisfy initial top-frame request #2974

Closed
DanTup opened this issue Dec 2, 2020 · 0 comments
Closed

Use the pause event's topFrame to satisfy initial top-frame request #2974

DanTup opened this issue Dec 2, 2020 · 0 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement is performance
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Dec 2, 2020

When the debugger pauses and we get a pauseEvent, it contains the topFrame of the stack. We currently ignore this, and when asked for the call stack, send a getStack() request to the VM.

VS Code asks us first for the top frame, and then for the next 20. We could save a round trip to the VM (and causing two concurrent getStack() requests) when the stackTraceRequest is for only the top frame and the current pauseEvent for the isolate contains a topFrame.

@DanTup DanTup added is enhancement in debugger Relates to the debug adapter or process of launching a debug session is performance labels Dec 2, 2020
@DanTup DanTup added this to the v3.18.0 milestone Dec 2, 2020
@DanTup DanTup modified the milestones: v3.18.0, v3.19.0 Dec 17, 2020
@DanTup DanTup closed this as completed in ea1a1e2 Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement is performance
Projects
None yet
Development

No branches or pull requests

1 participant