Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tree shows duplicate tests after discovering tests + running tests when using LSP on Windows #3052

Closed
BootBlock opened this issue Jan 5, 2021 · 1 comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug on windows
Milestone

Comments

@BootBlock
Copy link
Contributor

There appears to be someplace within the file loading chain that may be normalising file paths to lowercase, while other parts of Dart-Code are not normalising the paths and so paths to files are being seen as being different even though they're in actuality the same.

This results in an issue - and potentially others - of test tree node duplication when running tests as suite keys are specified via file path.

This only happens when LSP is enabled.

image

Note that the passed another_test.dart node is a duplication of the grey version below it; they're the same test(s) but seen as different due to casing differences as mentioned above.

Versions (please complete the following information):

  • VS Code version: 1.52.1
  • Dart extension version: 3.18
  • Dart/Flutter SDK version: 2.10.4 / 1.26.0-2.0.pre.170
@BootBlock BootBlock added this to the v3.19.0 milestone Jan 5, 2021
@DanTup DanTup changed the title Document paths have inconsistent casing in Windows Test tree shows duplicate tests after discovering tests + running tests when using LSP on Windows Jan 5, 2021
@DanTup DanTup added on windows in testing Relates to test execution of Dart/Flutter tests for end users labels Jan 5, 2021
@DanTup DanTup closed this as completed in d04e077 Jan 6, 2021
@DanTup
Copy link
Member

DanTup commented Jan 6, 2021

This was less of an issue than I thought it was giong to be - most places we already normalise the driver letter when converting from URIs to Paths (in fsPath). However this one is a "URI in a string" and did not.

I had a scan through other places using this, and don't think it should come up anywhere else, but I'll try to get the LSP tests merged into master so there's more coverage of LSP on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug on windows
Projects
None yet
Development

No branches or pull requests

2 participants