Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Run All Tests" command doesn't correctly mark tests as stale/remove them after a run #3058

Closed
DanTup opened this issue Jan 12, 2021 · 1 comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Jan 12, 2021

Given a test file like:

import 'package:test/test.dart';

void main() {
  test('1', () => expect(true, false));
}

If you:

  • Run with the Dart: Run All Tests command
  • Rename the test to 2
  • Re-run with the Dart: Run All Tests command

The old result for 1 remains in the test tree. Yet if you run the file with F5 or the Run CodeLens from the main function, it correctly is removed.

Possibly this is due to the "is new test run" flag (or the potentially deleted flags) not being set by the Run All Tests command?

@DanTup DanTup added the is bug label Jan 12, 2021
@DanTup DanTup added this to the v3.19.0 milestone Jan 12, 2021
@DanTup DanTup added the in testing Relates to test execution of Dart/Flutter tests for end users label Jan 12, 2021
@DanTup DanTup closed this as completed in 5420e50 Jan 25, 2021
@kentcb
Copy link

kentcb commented Feb 2, 2021

Thanks for fixing this! 😍 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug
Projects
None yet
Development

No branches or pull requests

2 participants