Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sort test suites by status during a run #3093

Closed
DanTup opened this issue Jan 23, 2021 · 1 comment
Closed

Don't sort test suites by status during a run #3093

DanTup opened this issue Jan 23, 2021 · 1 comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Jan 23, 2021

This causes them to jump around during the test run (eg. going from pass/fail to running/waiting and back).

@DanTup DanTup added is enhancement in testing Relates to test execution of Dart/Flutter tests for end users labels Jan 23, 2021
@DanTup DanTup added this to the v3.19.0 milestone Jan 23, 2021
@DanTup DanTup changed the title Don't sort test suites by status Don't sort test suites by status during a run Jan 23, 2021
@DanTup
Copy link
Member Author

DanTup commented Jan 23, 2021

Actually, this is intended to be handled as described here:

// To avoid the sort changing on every status change (stale, running, etc.) this
// field will be the last status the user would care about (pass/fail/skip).
// Default to Passed just so things default to the most likely (hopefully) place. This should
// never be used for rendering; only sorting.
protected _sort: TestSortOrder = TestSortOrder.Middle; // tslint:disable-line:variable-name

Might have become broken in the change from TestStatus -> Set<TestStatus> to support running skips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is enhancement
Projects
None yet
Development

No branches or pull requests

1 participant