Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running a specific test from the test tree/code-lens should always pass --run-skipped #3097

Closed
DanTup opened this issue Jan 25, 2021 · 1 comment · Fixed by #3101 or #3131
Closed
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Jan 25, 2021

No description provided.

@DanTup DanTup added is enhancement in testing Relates to test execution of Dart/Flutter tests for end users labels Jan 25, 2021
@DanTup DanTup added this to the v3.19.0 milestone Jan 25, 2021
DanTup pushed a commit that referenced this issue Jan 25, 2021
…de-lens

Fixes incorrect parameters being passed to `getLaunchConfig`.
Fixes #3097.
DanTup added a commit that referenced this issue Jan 29, 2021
This does not work for Flutter and needs redoing in a way that only is injected for Dart (and the menu items only show for it).

Fixes #3107, reopens #3048, reopens #3097.
@DanTup
Copy link
Member Author

DanTup commented Jan 29, 2021

This feature is being reverted due to #3107 - flutter test does not support --run-skipped so this needs be conditional based on the type of project each test node/CodeLens item is in (and better tested).

@DanTup DanTup reopened this Jan 29, 2021
@DanTup DanTup modified the milestones: v3.19.0, v3.20.0 Jan 29, 2021
DanTup pushed a commit that referenced this issue Feb 8, 2021
Applies to Dart-only projects as Flutter doesn't support --run-skipped.

Fixes #3097, #3107, #3048.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is enhancement
Projects
None yet
1 participant