Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build notifications uses Notifications instead of Window progress #3118

Closed
DanTup opened this issue Feb 2, 2021 · 0 comments · Fixed by #3123
Closed

Make build notifications uses Notifications instead of Window progress #3118

DanTup opened this issue Feb 2, 2021 · 0 comments · Fixed by #3123
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Feb 2, 2021

#2970 was intended to make hot reload/restart progress configurable, but leave build progress larger (notifications). However it appears the condition is accidentally make all non-hot-reload notifications smaller too.

The condition should be:

  • if not hot reload/hot restart, always Notification
  • else, use the config.hotReloadProgress setting to decide
@DanTup DanTup added is enhancement in flutter Relates to running Flutter apps in debugger Relates to the debug adapter or process of launching a debug session labels Feb 2, 2021
@DanTup DanTup added this to the v3.20.0 milestone Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant