Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline test descriptions not shown completely in test tree #3119

Closed
HerrNiklasRaab opened this issue Feb 2, 2021 · 4 comments
Closed
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug
Milestone

Comments

@HerrNiklasRaab
Copy link

See the test: "has not been synchronized with a bike,
than it should return false when calling isSynchronizedWith"

image

@DanTup
Copy link
Member

DanTup commented Feb 4, 2021

I guess we could replace these with spaces when setting the node label, although you're going to end up with a lot of whitespace in the name here: "bike, than it should". It may be better to use adjacent string literals to split the text over two lines, so there's no actual newline and/or indenting in the actual test name?

(btw, I think there are a few typos of "then" being "than" in there!)

@DanTup DanTup added this to the v3.20.0 milestone Feb 4, 2021
@DanTup DanTup added the in testing Relates to test execution of Dart/Flutter tests for end users label Feb 4, 2021
@HerrNiklasRaab
Copy link
Author

It may be better to use adjacent string literals to split the text over two lines, so there's no actual newline and/or indenting in the actual test name?

I agree, but I think it should still work. Either by making the entry in the test tree multiline, or replacing the line breaks with whitespaces.

@DanTup
Copy link
Member

DanTup commented Feb 4, 2021

Yep, agreed. I don't believe we can have multiline tree nodes (a VS Code limitation), but we can replace the newline. I'll fix that, but I mention it only because I think the spacing will still look weird for the example above, and I don't think it makes sense to try to massage the strings here (beyond the newline replacement).

@DanTup DanTup closed this as completed in 9cffc95 Feb 16, 2021
@DanTup
Copy link
Member

DanTup commented Feb 16, 2021

I ended up tidying the indentation anyway, so they look a little neater.

Screenshot 2021-02-16 at 18 54 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug
Projects
None yet
Development

No branches or pull requests

2 participants