Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme annotation token #3161

Closed
HadyMash opened this issue Feb 24, 2021 · 2 comments
Closed

Theme annotation token #3161

HadyMash opened this issue Feb 24, 2021 · 2 comments
Labels
in editor Relates to code editing or language features is enhancement
Milestone

Comments

@HadyMash
Copy link

Is your feature request related to a problem? Please describe.
There was previously an issue with the Preview LSP option where the UI Guides wouldn't work. When that was fixed, I turned it back on and noticed the syntax highlighting was different. I opened #3155 and I was able to change the colour of the variables. However, the @ and override have different colours and it doesn't match. Prior to turning on Preview LSP, using the One Dark Pro theme the @override would be pink. I do not care about what colour it is so long as they have the same colour.

Describe the solution you'd like
As advised by @DanTup in the previous issue, I would like to have a token for annotations so the @ colour can be customised.

Additional context
Issue #3155

@DanTup
Copy link
Member

DanTup commented Feb 25, 2021

I've changed annotations to by default be coloured the same as variables:

Screenshot 2021-02-25 at 11 36 17

This won't match perfectly if you use a constructor directly (@ClassFoo()) as classes are coloured slightly differently, but I think in most cases annotations are fields/getters.

You can also override the colour of the @ using the annotation token in your settings like:

"editor.semanticTokenColorCustomizations": {
	"rules": {
		"annotation": "#00ff00",
	},
},

@DanTup DanTup added this to the v3.20.0 milestone Feb 25, 2021
@DanTup DanTup closed this as completed in 81b7711 Feb 25, 2021
@DanTup DanTup added the in editor Relates to code editing or language features label Feb 25, 2021
@HadyMash
Copy link
Author

Thank you very much for your help @DanTup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants