Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames that produce no edits should not trigger VS Code refactor prompt #3253

Closed
DanTup opened this issue Apr 5, 2021 · 2 comments
Closed
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Apr 5, 2021

Renaming a .dart file that is not referenced in any imports currently still triggers the VS Code rename/refactor prompt.

@DanTup DanTup added is bug in editor Relates to code editing or language features labels Apr 5, 2021
@DanTup DanTup added this to the v3.22.0 milestone Apr 5, 2021
@DanTup
Copy link
Member Author

DanTup commented Apr 5, 2021

I've got a fix here (that may or may not be required), but it doesn't work correctly because of dart-lang/sdk#45593.

@DanTup DanTup added the blocked on dart / flutter Requires a change in Dart or Flutter to progress label Apr 5, 2021
DanTup added a commit that referenced this issue Apr 5, 2021
@DanTup DanTup removed the blocked on dart / flutter Requires a change in Dart or Flutter to progress label Apr 6, 2021
@DanTup
Copy link
Member Author

DanTup commented Apr 6, 2021

Between 749c2c8 and dart-lang/sdk#45593, this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug
Projects
None yet
Development

No branches or pull requests

1 participant