Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Embedded DevTools in VS Code Remote sessions #3274

Closed
DanTup opened this issue Apr 12, 2021 · 1 comment
Closed

Support Embedded DevTools in VS Code Remote sessions #3274

DanTup opened this issue Apr 12, 2021 · 1 comment
Labels
in commands Relates to commands (usually invoked from the command Palette) in remote Relates to running the extension in a remote setting using VS Code's remote dev support is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Apr 12, 2021

When DevTools is embedded in iframe, it doesn't go through exposeUrl so it doesn't work for remote workspaces. There may be other things that will prevent it working, but this should at least be fixed to see.

@DanTup DanTup added is bug in commands Relates to commands (usually invoked from the command Palette) in remote Relates to running the extension in a remote setting using VS Code's remote dev support labels Apr 12, 2021
@DanTup DanTup added this to the v3.22.0 milestone Apr 12, 2021
@DanTup DanTup changed the title Embedded DevTools does not work for remote workspaces Support DevTools in VS Code Remote sessions Apr 12, 2021
@DanTup
Copy link
Member Author

DanTup commented Apr 12, 2021

For cloud IDEs, this fails due to auth issues. It should be fine for VS Code remote though, so using this for fixing that, and #3275 for disabling embedded DevTools for environments that won't support it.

@DanTup DanTup changed the title Support DevTools in VS Code Remote sessions Support Embedded DevTools in VS Code Remote sessions Apr 12, 2021
@DanTup DanTup closed this as completed in fedbb51 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) in remote Relates to running the extension in a remote setting using VS Code's remote dev support is bug
Projects
None yet
Development

No branches or pull requests

1 participant