Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code completion incorrectly returns results in comments at end of file #3281

Closed
DanTup opened this issue Apr 15, 2021 · 1 comment
Closed
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Apr 15, 2021

The fix for #3170 only works if there is a newline after the comment or the offset of completion is not exactly at EOF.

@DanTup DanTup added is bug in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server labels Apr 15, 2021
@DanTup DanTup added this to the v3.22.0 milestone Apr 15, 2021
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Apr 15, 2021
Fixes Dart-Code/Dart-Code#3281

Change-Id: Ica8160977ac682dbf4db0f0b8a64a1ec0d2d9a2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195505
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member Author

DanTup commented Apr 15, 2021

Fixed by dart-lang/sdk@dc28e1f.

@DanTup DanTup closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug
Projects
None yet
Development

No branches or pull requests

1 participant