Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review auto-insertion of parens/arg placeholders in completion #3303

Closed
DanTup opened this issue Apr 26, 2021 · 2 comments
Closed

Review auto-insertion of parens/arg placeholders in completion #3303

DanTup opened this issue Apr 26, 2021 · 2 comments
Labels
in editor Relates to code editing or language features is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Apr 26, 2021

Sometimes this seems to insert even when they're already there after the caret.

@DanTup DanTup added is enhancement in editor Relates to code editing or language features labels Apr 26, 2021
@DanTup DanTup added this to the v3.22.0 milestone Apr 26, 2021
@DanTup
Copy link
Member Author

DanTup commented Apr 27, 2021

Concrete example:

Screenshot 2021-04-27 at 14 17 07

Screenshot 2021-04-27 at 14 17 11

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Apr 27, 2021
…hen they already exist

Fixes Dart-Code/Dart-Code#3303.

Change-Id: I284608ba850b5ed2008b8cdd707bc1becc73872d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197045
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member Author

DanTup commented Apr 27, 2021

Fixed by dart-lang/sdk@8f2c0e9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is enhancement
Projects
None yet
Development

No branches or pull requests

1 participant