Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Hierarchy should be display in sidebar and provide editor context menu #3313

Closed
tjx666 opened this issue May 1, 2021 · 4 comments
Closed

Type Hierarchy should be display in sidebar and provide editor context menu #3313

tjx666 opened this issue May 1, 2021 · 4 comments
Labels
in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.58.0

Comments

@tjx666
Copy link

tjx666 commented May 1, 2021

image
@tjx666
Copy link
Author

tjx666 commented May 1, 2021

It would be better to show the Type Hierarchy using visual graphic like Java class inheritance in IDEA.

image

@DanTup
Copy link
Member

DanTup commented May 10, 2021

Is this request related to the Type Hierarchy or Call Hierarchy?

There's an open issue at #612 for call hierarchy. I'd agree it makes sense to move the Type Hierarchy to a tree than where it is, although it would probably be better to try and get a standard LSP feature for this rather than custom messages - it looks like there's a PR in-progress at microsoft/language-server-protocol#1231. Doing it that way would allow VS Code to render this however it chooses (including visually) and be consistent for all languages.

@DanTup DanTup added blocked on vs code / lsp / dap Requires a change in VS Code to progress in lsp/analysis server Something to be fixed in the Dart analysis server labels May 10, 2021
@DanTup DanTup added this to the On Deck milestone May 10, 2021
@tjx666
Copy link
Author

tjx666 commented May 10, 2021

@DanTup Related to Type Hierarchy, and It seems that call Hierarchy not ready to use.

@DanTup DanTup removed the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Aug 8, 2022
@DanTup DanTup modified the milestones: On Deck, v3.48.0 Aug 8, 2022
@DanTup DanTup modified the milestones: v3.48.0, v3.50.0 Aug 25, 2022
@DanTup DanTup modified the milestones: v3.50.0, v3.52.0 Oct 3, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 13, 2022
@DanTup
[analysis_server] Add LSP Type Hierarchy
6f8d1e4 
Fixes Dart-Code/Dart-Code#3313.
Fixes Dart-Code/Dart-Code#2527.

Change-Id: I9f471fd3d7d55999795fee7ab4761e906566bd10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member

DanTup commented Oct 14, 2022

This is implemented by dart-lang/sdk@6f8d1e4. It ships in the Dart language server so will show up with a future SDK release (not a Dart-Code release).

@DanTup DanTup closed this as completed Oct 14, 2022
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Oct 14, 2022
@DanTup DanTup modified the milestones: v3.52.0, Next SDK Release Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.58.0
Development

No branches or pull requests
2 participants
@DanTup @tjx666