-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading notification does not disappear after app launches in release mode (or profile mode for web) #3338
Comments
It looks like this may be because we never get an |
I'm not familiar with the profile flag. Does that imply |
My understanding for non-web is that Profile mode is "almost a release mode" but still has some code to enable running profiling tools etc.
Ah, that's probably the issue here then. https://flutter.dev/docs/testing/build-modes says that a web app in profile mode is compiled with dart2js. In that case, Dart-Code should probably be aware that it's not going to get a VM Service URI for a web app in debug mode, and behave accordingly. |
Profile mode is Dart2JS. Profile mode is expected to match the characteristics of the release build app. |
Yeah that sounds like the issue. Long term we want to support better debugging tools for Dart2JS but it isn't a current priority. |
Do you mean this issue or the debugging tools for Dart2JS in general? |
Debugging tools for Dart2JS. |
This seems to affect Release mode for all platforms too - because we use the VM service as a signal for the app having finished loading, anything without a VM service will leave the loading toast visible. |
@grouma @jonahwilliams I've fixed this by not expecting to get a VM Service (
This doesn't seem ideal (although it may be slightly simpler if/when the debug adapter moves into flutter_tools), but I'm not sure there's an easy alternative. We may need to update this if either of those things change in future. |
@DanTup By this fix, Do I will be able to connect profile mode to Dev tools for Flutter web? |
@amr-eniou-3r not when running on web - my understanding from @grouma's comments above it that profile-mode on Web does not support the VM Service and therefore is not currently usable with DevTools. Profile mode for non-web should work though. This fix just prevents the loading notification from hanging around after the app launches (since it was previously waiting for a debugger connection that would never happen). |
Running in profile mode for web seems to get stuck with this notification. Split from #3206
The text was updated successfully, but these errors were encountered: