Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis errors are not reported for invalid filenames in conditional imports #3422

Closed
DanTup opened this issue Jun 21, 2021 · 1 comment
Closed

Analysis errors are not reported for invalid filenames in conditional imports #3422

DanTup opened this issue Jun 21, 2021 · 1 comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Milestone
v3.34.0

Comments

@DanTup
Copy link
Member

DanTup commented Jun 21, 2021

Split from #3071.

import 'image_cropper/cropper_stub.dart'
    if (dart.library.io) 'image_cropper/cropper_mobile.dart' // no error/warning if file doesn't exist
    if (dart.library.html) 'image_cropper/cropper_web.dart';
@DanTup DanTup added is bug in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server labels Jun 21, 2021
@DanTup DanTup added this to the On Deck milestone Jun 21, 2021
@DanTup DanTup mentioned this issue Jun 21, 2021
Closed
@DanTup DanTup modified the milestones: On Deck, v3.25.0 Jun 28, 2021
@DanTup DanTup modified the milestones: v3.25.0, v3.26.0 Jul 20, 2021
@DanTup DanTup modified the milestones: v3.26.0, On Deck Aug 24, 2021
@DanTup DanTup modified the milestones: On Deck, v3.30.0 Dec 2, 2021
@DanTup DanTup modified the milestones: v3.32.0, v3.34.0 Dec 29, 2021
@DanTup
Copy link
Member Author

DanTup commented Jan 5, 2022

This is available as a lint now: https://dart-lang.github.io/linter/lints/conditional_uri_does_not_exist.html

@DanTup DanTup closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Projects
None yet
Milestone
v3.34.0
Development

No branches or pull requests
1 participant
@DanTup