Analyzer plugin fixes and assists are not available when using LSP

[dkrutskikh]

Hi! I'm one of the authors of Dart Code Metrics, and we use analyzer plugin API (like sending AnalysisErrorFixes, etc.) to communicate with the analysis server. If I enable LSP preview in VSCode and have the plugin enabled, VSCode starts to display diagnostics without quick fixes. For example,

It works fine when LSP preview is disabled.

Could there be a problem with the analysis server?

Dart SDK version: 2.14.0-301.2.beta (beta) (Mon Jul 19 23:53:21 2021 +0200) on "macos_x64"
VSCode version: 1.58.0
Dart extension version: 3.24.2

[DanTup]

Are the fixes that are missing from your plugin, or all fixes? Could you try enabling the analysis servers instrumentation log to see if any errors are recorded?

If you can provide a small repro I can use (and confirm the exact version of the SDK you're using), that may help too. Thanks!

[dkrutskikh]

@DanTup please look at https://github.com/dkrutskikh/dart_lsp_quickfix_problem. Thanks!

[DanTup]

Thanks - I can repro this. Looks like plugin code actions were overlooked when implementing LSP. Working on it - sorry for the bother!

[DanTup]

I've got a change open to add this to the server: https://dart-review.googlesource.com/c/sdk/+/208404/

Since it's an SDK change, it will only show up in a future SDK release though (rather than Dart-Code release).

[dkrutskikh]

Thank you, please clarify this fix support new command https://dartcode.org/releases/v3-25/#fix-all-command?

[DanTup]

@dkrutskikh that new "fix all" command is equivalent to running "dart fix". It doesn't include all fixes, only a subset that have been chosen that are safe to apply together and that are very likely the correct fix for the error.

I don't think it includes plugins (or how feasible it would be) - @bwilkerson may have more information about this than I.

[dkrutskikh]

Anyway, thanks a lot!

[bwilkerson]

No, we don't currently have support for plugins to contribute to the set of fixes applied by the dart fix command. That support does seem like something we should look into adding, though there might be some interesting challenges around the area of conflicting edits. If that's a feature you're plugin would use, please open an issue here: https://github.com/dart-lang/sdk/issues/new.