Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch DevTools from "dart devtools" instead of "pub global" when using SDK >= 2.15 #3584

Closed
DanTup opened this issue Sep 29, 2021 · 2 comments
Labels
important Something important! in commands Relates to commands (usually invoked from the command Palette) is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Sep 29, 2021

See flutter/flutter#90894 (comment).

We can skip activating via Pub, checking for updates, etc. if we use the SDK-supplied command.

From flutter/flutter#90894 (comment)

2.15.0-39.0.dev is the earliest dart version this commit was included in.

@helin24 currently for internal workspaces we set startDevToolsFromDaemon and start from the Flutter daemon. I'm assuming that should remain as-is, but if that's no longer required let me know and I can remove it.

@DanTup DanTup added is enhancement in commands Relates to commands (usually invoked from the command Palette) labels Sep 29, 2021
@DanTup DanTup modified the milestones: v3.27.0, v3.28.0 Sep 29, 2021
@DanTup DanTup added the important Something important! label Oct 21, 2021
@DanTup DanTup closed this as completed in aad48f3 Oct 25, 2021
@helin24
Copy link
Contributor

helin24 commented Apr 15, 2022

@kenzieschmoll I believe we can use dart directly for internal workspaces, is that correct? Internal workspace's have a dart with a version above 2.15.0-39.0.dev and can therefore start devtools the same way? (asking now as I'm making this change for IntelliJ)

@kenzieschmoll
Copy link

there are pre-built binaries DevTools binaries in google3 that should be used to start devtools. The DevTools build bundled with the external Dart SDK is not the same as the google3 DevTools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Something important! in commands Relates to commands (usually invoked from the command Palette) is enhancement
Projects
None yet
Development

No branches or pull requests

3 participants