Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui Guides overlap indent guides #3585

Closed
rpiosi opened this issue Sep 29, 2021 · 5 comments
Closed

Ui Guides overlap indent guides #3585

rpiosi opened this issue Sep 29, 2021 · 5 comments
Labels
in editor Relates to code editing or language features is enhancement
Milestone

Comments

@rpiosi
Copy link

rpiosi commented Sep 29, 2021

Describe the bug
Ui Guides overlap indent guides so their usability is vastly decreased.

Expected behavior
Ui Guides are one pixel off the way the original guides. It will play nicely with the upcoming feature of adjustable Ui Guies color.

Screenshots
image

@rpiosi rpiosi added the is bug label Sep 29, 2021
@DanTup
Copy link
Member

DanTup commented Sep 29, 2021

This was intended. When the guides don't overlap, it looks like a bug that they're out of alignment:

Screenshot 2021-09-29 at 14 02 45

Personally I tend to turn off Indent Guides because they're quite busy with 2-space indenting.

The ideal solution would be to be able to render thicker lines over the top so it's more clear where they are. This requires new APIs from VS Code though - I would encourage adding 👍 to microsoft/vscode#73780. Until that issue (or something similar) is available, the UI Guidelines are likely to remain a little quirky (due to the way we have to render them) and behind a preview flag, because I don't really consider them of sufficient quality to ship enabled.

Hope this makes sense! If/when there are better APIs, I'll review how we render these and ensure they work better with the indent guides.

Thanks!

@DanTup DanTup removed the is bug label Sep 29, 2021
@rpiosi
Copy link
Author

rpiosi commented Sep 29, 2021

It might look broken indeed but after 5 minutes everyone will realize why they are ever so slightly moved :)

Ui guides serve different purpose and the solution is great to still be able to click around and see the code blocks what, when indentation is so tight, is critical, I'm very sure, for many.

@DanTup DanTup added this to the v3.27.0 milestone Sep 30, 2021
@DanTup DanTup added in editor Relates to code editing or language features is enhancement labels Sep 30, 2021
@DanTup
Copy link
Member

DanTup commented Sep 30, 2021

Ok, I've updated them to be 2px more to the right (as shown above). If we get better APIs for this we might want to try to do something that doesn't look so messy, but also doesn't obscure them - but that's a future problem.

I'll include this in the upcoming release (although it's not in Beta 2 released yesterday, and there may not be another beta before release).

@DanTup DanTup closed this as completed in a6695fc Sep 30, 2021
@rpiosi
Copy link
Author

rpiosi commented Oct 7, 2021

The updated Ui Guides feel amazing. Thank you Danny.
image

@DanTup
Copy link
Member

DanTup commented Oct 8, 2021

👍 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants