Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path weirdness in Testing pane #3643

Closed
timsneath opened this issue Oct 29, 2021 · 4 comments
Closed

Path weirdness in Testing pane #3643

timsneath opened this issue Oct 29, 2021 · 4 comments
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug
Milestone

Comments

@timsneath
Copy link
Contributor

Describe the bug
See screenshot: note that the path separator is inconsistent between front and backslashes:
image

Versions (please complete the following information):

  • VS Code version: 1.61.2
  • Dart extension version: 3.27.2
  • Dart/Flutter SDK version: master
@DanTup DanTup added this to the v3.28.0 milestone Oct 29, 2021
@DanTup DanTup added the in testing Relates to test execution of Dart/Flutter tests for end users label Oct 29, 2021
@DanTup DanTup closed this as completed in 4ea588a Nov 1, 2021
@DanTup
Copy link
Member

DanTup commented Nov 1, 2021

For consistency, this was supposed to always use forward slashes like URIs.

I need a lint for this almost-always-incorrect use of .replace() that often catches me out :-)

Screenshot 2021-11-01 at 10 48 06

@DanTup
Copy link
Member

DanTup commented Nov 1, 2021

That said, I'm not sure if using / on Windows here was the right call (is it a relative path, or a relative URI?). As someone who uses Windows more than me lately, if you think it may be better as \ let me know and I'll change. Thanks!

@timsneath
Copy link
Contributor Author

Windows should always be backslash for file paths, with the exception of the rarely used file URI (file:///c/src/win32/pubspec.yaml).

More recent versions of Windows are starting to become more tolerant of forward slashes (e.g. cd /src/win32 works), but it's not idiomatic Windows at all. I'd go backslash all the way unless you have a good reason to choose the alternative. 

@DanTup DanTup reopened this Nov 1, 2021
@DanTup
Copy link
Member

DanTup commented Nov 1, 2021

Yeah, sounds reasonable to me, will change before the release. Thanks!

DanTup added a commit that referenced this issue Nov 1, 2021
@DanTup DanTup closed this as completed in 884f115 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug
Projects
None yet
Development

No branches or pull requests

2 participants