Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support projects nested inside WorkspaceFolders in tasks like "dart: pub get" #3795

Closed
DanTup opened this issue Jan 20, 2022 · 1 comment
Closed
Labels
good first issue :octocat: A relatively straight forward issue that could be done by a new contributor in tasks Relates to VS Code tasks, such as those provided by Task Providers is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Jan 20, 2022

Eg. open the packages folder in the Flutter repo and try to run dart: pub get. It'll try to run in the root folder, but should instead be showing some picker to pick a project (if one can't be inferred).

This blocks #2924 because the current Pub Get command (etc.) all handle these projects correctly.

@DanTup DanTup added is enhancement in tasks Relates to VS Code tasks, such as those provided by Task Providers labels Jan 20, 2022
@DanTup DanTup added this to the v3.34.0 milestone Jan 20, 2022
@DanTup DanTup added the good first issue :octocat: A relatively straight forward issue that could be done by a new contributor label Jan 20, 2022
@DanTup
Copy link
Member Author

DanTup commented Jan 20, 2022

It might be difficult to do this without being able to visually distinguish the tasks for each folder in the UI:

microsoft/vscode#141063

@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Jan 20, 2022
@DanTup DanTup modified the milestones: v3.34.0, v3.36.0 Jan 20, 2022
@DanTup DanTup removed the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Jan 24, 2022
@DanTup DanTup closed this as completed in 8234794 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue :octocat: A relatively straight forward issue that could be done by a new contributor in tasks Relates to VS Code tasks, such as those provided by Task Providers is enhancement
Projects
None yet
Development

No branches or pull requests

1 participant