Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart syntax colors member variables with incorrect textmate scope. #3804

Closed
Scott-Tenera opened this issue Jan 29, 2022 · 1 comment
Closed
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@Scott-Tenera
Copy link

Observe the following screenshot.
dart_syntax

Member variables are given semantic coloring of function declaration.

This is reproducible with the following theme...

https://github.com/safield/ubuntu-monokai

@Scott-Tenera Scott-Tenera changed the title Dart syntax colors member variables with the color of functions. Dart syntax colors member variables with incorrect textmate scope. Jan 29, 2022
@DanTup
Copy link
Member

DanTup commented Jan 31, 2022

This seems to be a bad interaction between an original change for #3012 and the fix for #3618. The format was making property declarations coloured like methods to match the textmate grammar. However the latter had class fields marked as Properties to distinguish them from local variables.

I've removed the first, which means getter/setters will no longer be coloured like methods either (which is different to the textmate grammar, so they will change colour as semantic tokens become available), but considering the requirements I think it makes the most sense.

Before/After (the differences are on line 11-13):

Screenshot 2022-01-31 at 10 28 28

@DanTup DanTup added this to the v3.34.0 milestone Jan 31, 2022
@DanTup DanTup added the in editor Relates to code editing or language features label Jan 31, 2022
@DanTup DanTup closed this as completed in a5d6f6b Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

2 participants