Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argument "--machine" disables "--multidex" #3837

Closed
MCredbear opened this issue Feb 18, 2022 · 5 comments · Fixed by flutter/flutter#101689
Closed

argument "--machine" disables "--multidex" #3837

MCredbear opened this issue Feb 18, 2022 · 5 comments · Fixed by flutter/flutter#101689
Labels
in flutter Relates to running Flutter apps is bug
Milestone

Comments

@MCredbear
Copy link

Describe the bug
As we know --machine is a default argument of this plugin (At spawnRunDaemon()), but it can fail --multidex which is a required one for new Android Apps.
Usually, --multidex is default to be enabled, and if it isn't enabled and it's required, the SDK would report.
But after adding --machine, although you have added --multidex, the SDK still tells yout to add it.

  • VSCodium version: 1.64.2
  • Dart extension version: 3.34.0
  • Dart/Flutter SDK version: 2.11.0-0.0.pre.501
@DanTup
Copy link
Member

DanTup commented Feb 22, 2022

I think this is something that will need handling in the flutter tool (https://github.com/flutter/flutter/). I'm not very familiar with multidex though - if you can provides steps for me to reproduce this issue I can have a look. Thanks!

@DanTup DanTup added the awaiting info Requires more information from the customer to progress label Feb 22, 2022
@MCredbear
Copy link
Author

MCredbear commented Feb 23, 2022

I think this is something that will need handling in the flutter tool (https://github.com/flutter/flutter/). I'm not very familiar with multidex though - if you can provides steps for me to reproduce this issue I can have a look. Thanks!

This is my code: https://github.com/MCredbear/netease_cloudmusic_flutter
Clone it and open it in VSCode, delete line 51 and 69 in android/app/build.gradle, then press F5, then you will see the error

@github-actions
Copy link

This issue has been marked stale because it is tagged awaiting-info for 20 days with no activity. Remove the stale label or comment to prevent the issue being closed in 10 days.

@github-actions github-actions bot added the stale Will be closed soon if no response. label Mar 16, 2022
@DanTup DanTup added upstream in dart / flutter Needs changing in Dart or Flutter and removed awaiting info Requires more information from the customer to progress stale Will be closed soon if no response. labels Mar 16, 2022
@DanTup DanTup added this to the On Deck milestone Mar 16, 2022
@DanTup
Copy link
Member

DanTup commented Mar 16, 2022

Sorry I didn't respond - have started looking at this over at flutter/flutter#99010, but need some input from someone on the Flutter team. I've removed the awaiting-info tag and will update here when that progresses. Thanks!

@DanTup DanTup modified the milestones: On Deck, v3.40.0 Apr 11, 2022
@DanTup DanTup added in flutter Relates to running Flutter apps and removed upstream in dart / flutter Needs changing in Dart or Flutter labels Apr 11, 2022
@DanTup
Copy link
Member

DanTup commented Apr 11, 2022

Fixed by flutter/flutter#101689. Since the fix is in the Flutter SDK, it'll show up in a future Flutter release rather than a VS Code extension release.

@DanTup DanTup closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in flutter Relates to running Flutter apps is bug
Projects
None yet
2 participants