"Extract Method" should run checks before asking for a method name

[chrisnorman7]

When choosing the "Extract Method" option from the refacturing menu, you are asked for the name before the plugin checks if the closure can be extracted.

It would seem more ergonomic to perform checks before asking for the name, so that the plugin isn't offering to let you do something that will ultimately fail.

[DanTup]

This isn't done yet - it needs an SDK change to match.

[DanTup]

SDK work landed in dart-lang/sdk@f4b273e.

[chrisnorman7]

Great stuff, thank you for all your hard work. Take care, Chris Norman

…

On Mon, 4 Apr 2022 at 10:48, Danny Tuppeny ***@***.***> wrote: Closed #3872 <#3872>. — Reply to this email directly, view it on GitHub <#3872 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUZ2P6WU75AXCL4X5EPQ3VDK3G5ANCNFSM5QSBM6ZQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[DanTup]

np, thanks for the report!

To get the fix, you'll need the new version of Dart-Code (hopefully shipping today) and also a Dart SDK with the change above (and its version number must be at least 2.17.0). I don't know when the SDKs will next ship, but it'll just automatically start working once you have all the relevant versions.

[chrisnorman7]

Great stuff, thank you again. Take care, Chris Norman

…

On Mon, 4 Apr 2022 at 12:07, Danny Tuppeny ***@***.***> wrote: np, thanks for the report! To get the fix, you'll need the new version of Dart-Code (hopefully shipping today) and also a Dart SDK with the change above (and its version number must be at least 2.17.0). I don't know when the SDKs will next ship, but it'll just automatically start working once you have all the relevant versions. — Reply to this email directly, view it on GitHub <#3872 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUZ2I6ALOWVEYQPSJKOJDVDLEPDANCNFSM5QSBM6ZQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>