Code completion for zero-argument functions should position the text cursor after the completion #3873
Labels
in editor
Relates to code editing or language features
in lsp/analysis server
Something to be fixed in the Dart analysis server
is bug
Milestone
Comments
DanTup
added
in editor
|
Yep, this comes from the LSP server. I've got a fix at https://dart-review.googlesource.com/c/sdk/+/238088/. Since it's in the LSP Server, it'll show up in an SDK update rather than a VS Code extension update. I'll close this once the change lands. Thanks! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Mar 23, 2022
…s with 0 parameters Fixes Dart-Code/Dart-Code#3873. Change-Id: I66a5b18dcf0674454cfc820d6cdf0d84e4c4f547 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238088 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
|
Fixed by dart-lang/sdk@13593b9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To Reproduce
Steps to reproduce the behavior:
var s = 'HELLO WORLD'.toL. Completion suggests the.toLowerCase()method.Result:
VS Code completes
.toLowerCase()but positions the text cursor between the parentheses.Expected behavior
Since the completed method is known to take zero arguments, positioning the text cursor between the parentheses seems pointless. I instead expected the text cursor to be after
.toLowerCase(). After completion, I quickly typed;and theEnterkey before realizing what happened, and undoing the damage took additional effort.I'm not sure if this is something that the Dart extension can do something about or if it's how code completion works in VS Code in general.
Versions (please complete the following information):
The text was updated successfully, but these errors were encountered: