Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VS Code's env.isTelemetryEnabled flag as telemetry opt-in #3874

Closed
DanTup opened this issue Mar 15, 2022 · 1 comment
Closed

Use VS Code's env.isTelemetryEnabled flag as telemetry opt-in #3874

DanTup opened this issue Mar 15, 2022 · 1 comment

Comments

@DanTup
Copy link
Member

DanTup commented Mar 15, 2022

VS Code has a shared flag for extensions to use (env.isTelemetryEnabled) so that each extension doesn't do its own prompting.

We should switch to this, but still honour any explicit opt-outs from dart.allowAnalytics, but hide that setting and update any docs about it to point to the VS Code switch.

https://code.visualstudio.com/api/references/vscode-api#env.isTelemetryEnabled

@DanTup DanTup added this to the v3.38.0 milestone Mar 15, 2022
@DanTup
Copy link
Member Author

DanTup commented Mar 16, 2022

The text for this setting suggests it's only for first party collection now, which doesn't seem to match the intention of env.isTelemetryEnabled 🤔

Controls all core and first party extension telemetry. This helps us to better understand how Visual Studio Code is performing, where improvements need to be made, and how features are being used. Read more about the data we collect and our privacy statement. A full restart of the application is necessary for crash reporting changes to take effect.

Note: If/when switching to this, we also need to either listen to env.onDidChangeTelemetryEnabled or ensure we read the latest value of env.isTelemetryEnabled at the point of sending the metrics.

@DanTup DanTup closed this as completed in d8ed362 Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant