Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap with widget inserts snippet placeholders on latest Flutter builds #3877

Closed
maheshmnj opened this issue Mar 18, 2022 · 9 comments
Closed
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@maheshmnj
Copy link

To Reproduce
Steps to reproduce the behavior:

  1. Right-click any widget
  2. Choose Wrap with Widget

Expected behavior
Widget should be wrapped with another widget

Actual Results

Screenshots

Screen.Recording.2022-03-18.at.11.36.46.AM.mov

Versions (please complete the following information):

  • VS Code version:
Version: 1.65.2
Commit: c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1
Date: 2022-03-10T14:42:05.236Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin arm64 21.3.0

Even pre-release version of the plugin reproduces the issue

  • Dart extension version: v3.36.0
  • Dart/Flutter SDK version: v3.36.0
@DanTup DanTup added this to the v3.38.0 milestone Mar 18, 2022
@DanTup DanTup added the in editor Relates to code editing or language features label Mar 18, 2022
@DanTup
Copy link
Member

DanTup commented Mar 18, 2022

Thanks for the report. This was caused by a recent improvement in the anlaysis server that exposed a bug in the extension. It's fine in Flutter's stable channel, but broken on more recent development builds.

The issue is fixed by 84fc046. It hasn't made a stable release yet, but it is in the pre-releases version that you can switch to in VS Code using the buttons shown in the screenshot below (you should change both and keep them to the same channel, though it's the Dart extension that contains this fix).

Dart/Flutter pre-release versions

Thanks!

@DanTup DanTup closed this as completed Mar 18, 2022
@DanTup DanTup changed the title Wrap with widget broken Wrap with widget inserts snippet placeholders on latest Flutter builds Mar 18, 2022
@maheshmnj
Copy link
Author

Thanks, @DanTup, I can confirm using the prerelease version of both the plugins, fixes the issue.

@DanTup
Copy link
Member

DanTup commented Mar 18, 2022

Great, thanks for confirming! If it keeps coming up, I'll do a patch release with that fix in. Otherwise releases usually ship at the end/start of the month.

@Pablo-hub44
Copy link

not works

@DanTup
Copy link
Member

DanTup commented Jun 22, 2022

@Pablo-hub44 please provide some more information about what isn't working. A screenshot would be useful, and please include the versions of your Dart extension, and the full output of flutter doctor -v.

@jonatandorozco
Copy link

Not working yet.

Dart extension version: v3.43.20220628
Flutter extension version: v3.43.20220621
Flutter version: 2.10.5

image

Flutter doctor output

[√] Flutter (Channel stable, 2.10.5, on Microsoft Windows [Versión 10.0.19044.1766], locale es-CO)
    • Flutter version 2.10.5 at D:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5464c5bac7 (2 months ago), 2022-04-18 09:55:37 -0700
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[√] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at D:\androidSdk
    • Platform android-32, build-tools 32.1.0-rc1
    • ANDROID_SDK_ROOT = D:\androidSdk
    • Java binary at: C:\Users\jonor\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\212.5712.43.2112.8609683\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • CHROME_EXECUTABLE = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe

[√] Visual Studio - develop for Windows (Visual Studio Build Tools 2019 16.11.9)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
    • Visual Studio Build Tools 2019 version 16.11.32106.194
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.1)
    • Android Studio at C:\Users\jonor\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\211.7628.21.2111.8309675
    • Flutter plugin version 67.1.1
    • Dart plugin version 211.7817
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Users\jonor\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\212.5712.43.2112.8609683
    • Flutter plugin version 68.1.2
    • Dart plugin version 212.5744
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] VS Code (version 1.68.1)
    • VS Code at C:\Users\jonor\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.43.20220621

[√] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12 (API 32) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Versión 10.0.19044.1766]
    • Chrome (web)                 • chrome        • web-javascript • unknown
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 103.0.1264.37

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@DanTup
Copy link
Member

DanTup commented Jun 29, 2022

@jonorozcoc can you verify you've reloaded VS Code since the extension update was installed, and if so follow the instructions here to capture a log (in a new sample project, since it will contain parts of your source code) and file a new issue with it attached:

#3956 (comment)

Thanks!

@DanTup DanTup reopened this Jun 29, 2022
@DanTup
Copy link
Member

DanTup commented Jun 29, 2022

(didn't mean to re-open this, please file a new issue with the log)

@DanTup DanTup closed this as completed Jun 29, 2022
@jonatandorozco
Copy link

Thanks @DanTup for your quick response. I'll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

4 participants