Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug Adapter has unhandled promise rejections unsetting breakpoints #3918

Closed
DanTup opened this issue Apr 8, 2022 · 0 comments
Closed

Debug Adapter has unhandled promise rejections unsetting breakpoints #3918

DanTup opened this issue Apr 8, 2022 · 0 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Milestone
v3.40.0

Comments

@DanTup
Copy link
Member

DanTup commented Apr 8, 2022

The cause of #3916 is unhandled rejections when removing breakpoints.

This is likely caused by new thread registrations resetting all breakpoints (not just the new thread), and if multiple overlap, they may try to remove the same breakpoints at the same time (and subsequent calls fail with "invalid params").
@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Apr 8, 2022
@DanTup DanTup added this to the v3.40.0 milestone Apr 8, 2022
DanTup added a commit that referenced this issue Apr 8, 2022
@DanTup
Prevent unhandled promise rejections from terminating the DA
10a1bd3 
Fixes #3916 by restoring the previous behaviour on older Node versions.

Opened #3918 for a proper fix to any places that are allowing promises to go unhandled.
@DanTup DanTup mentioned this issue Apr 8, 2022
Closed
@DanTup DanTup closed this as completed in 8b09f57 Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Projects
None yet
Milestone
v3.40.0
Development

No branches or pull requests
1 participant
@DanTup