Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart SDK Repo is no longer detected correctly #3933

Closed
DanTup opened this issue Apr 19, 2022 · 0 comments
Closed

Dart SDK Repo is no longer detected correctly #3933

DanTup opened this issue Apr 19, 2022 · 0 comments
Labels
is bug
Milestone
v3.40.0

Comments

@DanTup
Copy link
Member

DanTup commented Apr 19, 2022

We usually detect when you're in the Dart SDK repo and disable any "pub get" prompts or automatic fetching of packages. This check was done by looking for:

  • README.dart-sdk
  • .dart_tool/package_config.json

Since dart-lang/sdk@47c011a, the second file no longer exists. We need to tweak this check (or figure out something more generic for non-Pub workspaces).
@DanTup DanTup added the is bug label Apr 19, 2022
@DanTup DanTup added this to the v3.40.0 milestone Apr 19, 2022
@DanTup DanTup closed this as completed in e46b724 Apr 19, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is bug
Projects
None yet
Milestone
v3.40.0
Development

No branches or pull requests
1 participant
@DanTup