Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics re-order during typing #3934

Closed
DanTup opened this issue Apr 19, 2022 · 1 comment
Closed

Diagnostics re-order during typing #3934

DanTup opened this issue Apr 19, 2022 · 1 comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug
Milestone
v3.40.0

Comments

@DanTup
Copy link
Member

DanTup commented Apr 19, 2022

Splitting from #3928:

Apr-19-2022 16-45-06

Typing can cause the same errors to change order, which has a negative impact on using the Peek Problem view, which maintains the selected diagnostic by its index in the collection.
@DanTup DanTup added is bug in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server labels Apr 19, 2022
@DanTup DanTup added this to the v3.40.0 milestone Apr 19, 2022
@DanTup DanTup mentioned this issue Apr 19, 2022
Closed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 20, 2022
@DanTup
[analyzer] Use LinkedHashSet for recording errors to keep order consi…
147dca3 
…stent

Fixes Dart-Code/Dart-Code#3934.

Change-Id: I1cd9fd35ddbbd768877e6b2b2984056ed5ec5d9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member Author

DanTup commented Apr 20, 2022

Fixed by dart-lang/sdk@147dca3.

@DanTup DanTup closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug
Projects
None yet
Milestone
v3.40.0
Development

No branches or pull requests
1 participant
@DanTup