Autocomplete for symbols from package:charcode ends up with duplicated dollar ($) characters #3943
Comments
It looks like for "external" items, we don't provide the
This is not valid, so I'm not sure how we ended up doing this. What's happening here is that VS Code is guessing which range to replace (since the lazy-computed one from the server is too late), and it doesn't know that |
DanTup
added
in editor
|
Fixing this by adding the edits to every completion item bloats the payload quite significantly, so I'm going to bump fixing this until next month, when LSP 3.17 should have been released and we can use |
Not providing textEdit means that the client will use insertText and compute its own range for what needs to be replaced. This may be incorrect if the name includes symbols that VS Code doesn't realise are part of the identifier. To fix this, we should _always_ supply the range. This will result in a slightly larger payload, although an upcoming change to use itemDefaults will remove that for supporting clients. Fixes Dart-Code/Dart-Code#3943. Change-Id: Ifd3f38ef96fecc6c745e00f511eb0bdbbd0d4a82 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248143 Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
|
Fixed by dart-lang/sdk@40e25eb. |
Describe the bug
When I attempt to autocomplete the generated symbols from
package:charcodethat start with a$character, the autocompleted symbol ends up with$$.To Reproduce
import 'package:charcode/charcode.dart';to some.dartfile.$ba. The autocomplete list appears, listing$backquote,$backslash, ...$bagets autocompleted to$$backquote.Expected behavior
$bashould have been autocompleted to$backquote.Other notes
Strangely, if I define my own variable (e.g.
var $foo = 'bar';), then that seems to autocomplete fine. I'm not sure why the symbols frompackage:charcodeare autocompleting differently.Versions
The text was updated successfully, but these errors were encountered: